Spacing: fix block error if spacing unit array empty in theme.json #56306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: -2 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ramonjd
reviewed
Nov 21, 2023
ramonjd
approved these changes
Nov 21, 2023
apeatling
reviewed
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a check to make sure that the spacing units array first entry is set before falling back to it as a default, and also adds a
minItemssetting to thetheme.jsonschema.Why?
Currently if a theme author adds an empty
unitsarray totheme.jsonany blocks that use spacing settings will crash in the editor.Fixes: #56176
How?
selectedUnitdefinition"minItems": 1to the json schema for the spacing settingsTesting Instructions
theme.jsonadd and empty spacing units array, eg.settings.spacing.units: []lib/theme.jsonto `"$schema": "../schemas/json/theme.json"Screenshots or screencast
Before:
units-before.mp4
After:
units-after.mp4