Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link preview image to live example using WordPress Playground #56292

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

juanmaguitar
Copy link
Contributor

@juanmaguitar juanmaguitar commented Nov 18, 2023

Embed preview of the example in the Handbook page using iframe and WordPress Playground

Unfortunately, GitHub doesn't seem to allow iframe due to security reasons, so a workaround could be providing an image with the preview linked to the live example using WordPress Playground

Embed preview of the example using iframe and WordPress Playground
@juanmaguitar juanmaguitar changed the title Embed preview of the example using iframe and WordPress Playground Link preview image to live example using WordPress Playground Nov 18, 2023
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanmaguitar Image needs ALT text to describe where the link is going.

docs/how-to-guides/data-basics/README.md Outdated Show resolved Hide resolved
@juanmaguitar
Copy link
Contributor Author

juanmaguitar commented Nov 19, 2023

@juanmaguitar Image needs ALT text to describe where the link is going.

Thanks a lot, @alexstine! I came back to the PR to add exactly that 🙂

@juanmaguitar juanmaguitar added the [Type] Developer Documentation Documentation for developers label Nov 19, 2023
Copy link

github-actions bot commented Nov 19, 2023

Flaky tests detected in 0fc1847.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6927883788
📝 Reported issues:

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanmaguitar A lot of screen readers still ignore the `title attribute so the ALT text here needs to communicate where the link goes, not what the screenshot shows. ALT text should always describe the image excluding the times when the image is a link, then the destination page should be described.

docs/how-to-guides/data-basics/README.md Outdated Show resolved Hide resolved
@juanmaguitar
Copy link
Contributor Author

@juanmaguitar A lot of screen readers still ignore the `title attribute so the ALT text here needs to communicate where the link goes, not what the screenshot shows. ALT text should always describe the image excluding the times when the image is a link, then the destination page should be described.

@alexstine I wasn't aware of this. Thanks for the clarification! I have approved your suggestion.

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juanmaguitar juanmaguitar merged commit 02c0fc6 into trunk Nov 20, 2023
50 checks passed
@juanmaguitar juanmaguitar deleted the data-basics-tutorial-embed-demo-iframe-playground branch November 20, 2023 15:05
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants