-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link preview image to live example using WordPress Playground #56292
Link preview image to live example using WordPress Playground #56292
Conversation
Embed preview of the example using iframe and WordPress Playground
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanmaguitar Image needs ALT text to describe where the link is going.
Co-authored-by: Alex Stine <[email protected]>
Thanks a lot, @alexstine! I came back to the PR to add exactly that 🙂 |
Flaky tests detected in 0fc1847. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6927883788
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanmaguitar A lot of screen readers still ignore the `title attribute so the ALT text here needs to communicate where the link goes, not what the screenshot shows. ALT text should always describe the image excluding the times when the image is a link, then the destination page should be described.
Co-authored-by: Alex Stine <[email protected]>
@alexstine I wasn't aware of this. Thanks for the clarification! I have approved your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Embed preview of the example in the Handbook page using iframe and WordPress PlaygroundUnfortunately, GitHub doesn't seem to allow
iframe
due to security reasons, so a workaround could be providing an image with the preview linked to the live example using WordPress Playground