Extract a PostPanelRow component from the different sidebar panels #56238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
Size Change: -115 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Base automatically changed from
update/unify-schedule-post-component
to
trunk
November 17, 2023 10:21
youknowriad
force-pushed
the
update/extract-post-panel-row-component
branch
from
cce18b7 to
b5b713d
Compare
youknowriad
commented
Nov 17, 2023
| <PostSticky /> | ||
| <PostPendingStatus /> | ||
| <PostFormat /> | ||
| <PostSlug /> | ||
| <PostAuthor /> | ||
| <PostSyncStatus /> |
There was a problem hiding this comment.
I moved this because it actually looks way better before the "pending status". Check by opening a reusable block in the post editor.
There was a problem hiding this comment.
I'm not sure how to view this component 😅
There was a problem hiding this comment.
You click on the "manage all patterns" link in the more menu of the post editor and then create a pattern/reusable block from there.
ntsekouras
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that we keep repeating the same styles over and over between the different panels in the "summary" panel in the site editor sidebar (or post editor).
This PR just creates a small internal UI component to reuse between the different panels.