Site Editor Sidebar: fix actions vertical alignment #56218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Nov 16, 2023
jameskoster
approved these changes
Nov 16, 2023
andrewserong
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Thanks for fixing this one up! I had the same idea over in #56233 but missed that you'd already opened a PR 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a layout bug discovered in #55360 (review)
Why?
Changes from #55360 caused this misalignment as a side effect
How?
Setting the parent actions wrapper as a flexbox parent correctly aligns all action icon buttons
Testing Instructions
Screenshots or screencast