Site editor: redirect to main page menu if page record not found #56177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een found, probably deleted.
ramonjd
added
[Type] Enhancement
|
Size Change: +891 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ramonjd
changed the title
apeatling
reviewed
Nov 17, 2023
There was a problem hiding this comment.
Confirmed this hangs on trunk:
On this branch confirmed that there is no hang, and it directs to a different page. One issue -- what page is it redirecting to? It isn't the first page in the list, and I don't even see it in the left menu (I have a lot of dummy pages). Could we select the first page?
Screen.Recording.2023-11-17.at.1.35.22.PM.mov
Thanks for testing. It should just open the Pages list and load the home template, which is the default behaviour when opening this view ( So the screen recording in this comment is expected.
That's possible. It would depart from the default behaviour, so I'd say if we selected the first page on a 404 redirect, maybe we should do the same when landing on |
apeatling
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a test. It might not work.
This PR redirects to
/pagewhen a record has resolved but has not been found, probably deleted.2023-11-16.09.18.24.mp4
Why?
At the moment the site editor will hang if it tried to load an entity that does not exist.
This applies also for templates etc, but starting with pages to test out the approach.
How?
Pushing an entry to the history.
TODO
Add E2E test
Testing Instructions
Try to navigate to a page that has been deleted, e.g.,
/wp-admin/site-editor.php?postType=page&postId=37&canvas=editEven better, create a page and navigate to the site editor > pages.
Delete the page in another tab, then back in the site editor, try to open that page.
Observe that you're redirected to
/pages.Check that loading existing pages works!