Global Styles: Make search more responsive for block type list #56139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
Size Change: +404 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Nov 16, 2023
packages/edit-site/src/components/global-styles/screen-block-list.js
Outdated
Show resolved
Hide resolved
ntsekouras
approved these changes
Nov 16, 2023
|
I think @tyxla did a similar optimization for the Inserter but with debouncing. Maybe we can swap that. The “native” solution should be more performat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR improves perceived performance when searching for a block in the Global Styles block types list.
The screencasts below are without CPU throttling, but the difference is more visible when it's enabled.
Why?
Searching for a block type was sluggish.
How?
See: https://react.dev/reference/react/useDeferredValue#deferring-re-rendering-for-a-part-of-the-ui
Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast
CleanShot.2023-11-15.at.16.49.43.mp4
CleanShot.2023-11-15.at.16.50.31.mp4