DropdownMenu: remove extra vertical space around the toggle button #56136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
changed the title
ciampo
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Nov 15, 2023
|
Thanks for the follow-up! 🎉 |
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Supersedes #56005
This PR tweaks the vertical alignment of the menu toggle for the
DropdownMenucomponentWhy?
These changes prevent some unwanted vertical space from being added under the dropdown menu toggle, as initially flagged in #56002 (comment)
How?
DropdownMenuinternally uses theDropdowncomponent. Since we established that it would be risky to tweak thedisplayproperty of theDropdownwrapper element, we opted for removing the unwanted vertical space by setting thevertical-alignCSS property in theDropdownMenucomponent.As also noted elsewhere, this PR will only remove such vertical space on the
DropdownMenucomponent. Consumers ofDropdownwill have to provide a similar "fix" directly when using the component.Testing Instructions
trunkDropdownMenustorybook example. Inspect the dropdown menu's toggle, and notice how, while thebuttonelement is 24px tall, the surroundingdiv(with classname.components-dropdown-menu) has a height of 27px.divwrapping the toggle should now have the same height as the toggle (24px)