Page spec: merging create page and toggle preview tests #56129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +390 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ramonjd
added
[Type] Task
There was a problem hiding this comment.
This is looking great to me @ramonjd, nice work consolidating the tests while keeping them as separate functions to improve readability. By combining the two tests, the net result is a reduction in around 9–10 seconds in test execution for me in my local environment:
Before
After
Just left a comment about one of the comments, and about the linter complaining that the combined test doesn't have any assertions. Other than that, it's looking good. Is this ready to be switched over to ready for review, or are you still drafting? 🙂
Update commentszz
Thanks again for the idea! That's almost enough time to take a deep sip of tea. Perfect! |
andrewserong
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Follow up to #56096
This PR merges the create page and toggle preview tests because they rely on the same page content to work.
It also speeds up the test suite a little because we don't have to reload the page.
The PR also changes the test to check for consistent block order between toggling template preview.
#56096 was testing the presence and order of paragraph blocks, but since they're contained in a single post content block it didn't achieve it's purpose: to test that template changes, e.g., changing the order of post title and post content blocks, are reflected when template preview is toggled to "off".
Testing Instructions
Run the tests using the sweet playwright UI tool!!
npm run test:e2e:playwright -- --ui --headed