Background Image Support: Hide the background image reset button when there's no image #55973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Side note: While working on this, I noticed that when you reset the image from I can reproduce it on the trunk, so it's probably a different issue with the tools panel. Will investigate separately. ScreencastCleanShot.2023-11-08.at.19.50.44.mp4 |
|
@Mamaduka can we tag this as a fix for 6.4.1? |
|
@richtabor, it should be okay, as this fixed a missed bug in WP 6.4. cc @mikachan |
Mamaduka
added
the
Backport to WP Minor Release
|
Thanks for the quick fix! 🙇 |
The ToolsPanel always shows a |
|
Update: @Mamaduka and @richtabor I just gave this a test on 2023-11-09.10.20.53.mp4I wonder if we can explicitly set focus to the |
|
Update to the update: I have a fix for the focus loss issue up over in #55984 — the idea there is to shift focus and simulate a click on the toggle button to close the dropdown and move focus to the toggle button when the background image is reset. I think that should hopefully get us back to the desired keyboard accessibility while preserving this fix! 🤞 |
mikachan
pushed a commit
that referenced
this pull request
Nov 9, 2023
|
I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: b1b4034 |
mikachan
removed
the
Backport to WP Minor Release
mikachan
pushed a commit
that referenced
this pull request
Nov 13, 2023
cbravobernal
pushed a commit
that referenced
this pull request
Nov 14, 2023
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #55969
PR hides the "Reset" button for the background image block support panel when there's no image.
Why?
See #55969
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2023-11-08.at.19.34.55.mp4