Tooltip: Don't render buttons tooltip when show button text labels is enabled #55842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +137 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9ac209a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6745103354
|
afercia
force-pushed
the
fix/buttons-tooltip-when-show-button-text-labels-on
branch
from
9ac209a to
bd8f152
Compare
|
Rebased on top of latest trunk. I'd appreciate a quick review @carolinan or @tellthemachines when you have a chance, please 🙏 |
Oh yes thank you @tellthemachines, added it 👍 I updated the test instructions accordingly. |
tellthemachines
approved these changes
Nov 23, 2023
afercia
deleted the
fix/buttons-tooltip-when-show-button-text-labels-on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55815
What?
Buttons that already show visible text don't need a tooltiip that just repeats the visible text.
Why?
Unnecessarily clutters the UI.
How?
Use the
showTooltipprop based on theshowIconLabelspreference.Testing Instructions
Note: the 'Save/Saved' button does have the same problem but for now we have to force its tooltip to always render as explained in this comment.
Testing Instructions for Keyboard
Screenshots or screencast