Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroupControl: Add opt-in prop for 40px default size #55789

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

brookewp
Copy link
Contributor

@brookewp brookewp commented Nov 1, 2023

Part of #46741

What?

Add a new opt-in prop __next40pxDefaultSize to ToggleGroupControl, following the plan outlined in above mentioned PR.

Why?

For more consistency in styling.

How?

A new, temporary __next40pxDefaultSize prop. When the prop is set to true, the height will be 40px instead of 36px.

Testing Instructions

In Storybook:

  1. npm run storybook:dev
  2. Set __next40pxDefaultSize to true
  3. The height of the component should now be 40px instead of the default 36px

In the editor

Smoke test the component in the editor; ToggleGroupControl shouldn't have any visible changes for now.

@brookewp brookewp added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Nov 1, 2023
@brookewp brookewp self-assigned this Nov 1, 2023
@brookewp
Copy link
Contributor Author

brookewp commented Nov 2, 2023

End-to-End Tests / Puppeteer - 3 (pull_request) is failing but I see it's failing when running locally against trunk.

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ciampo
Copy link
Contributor

ciampo commented Nov 3, 2023

End-to-End Tests / Puppeteer - 3 (pull_request) is failing but I see it's failing when running locally against trunk.

Sounds good. We can merge this PR once the tests are passing again on trunk.

@brookewp brookewp force-pushed the add/40px-size-togglegroupcontrol branch from b1b34ba to 93bef5c Compare November 6, 2023 20:20
@brookewp brookewp force-pushed the add/40px-size-togglegroupcontrol branch from 93bef5c to 845bdc3 Compare November 6, 2023 20:27
Copy link

github-actions bot commented Nov 6, 2023

Flaky tests detected in 845bdc3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6776166039
📝 Reported issues:

@brookewp brookewp merged commit f4389b9 into trunk Nov 6, 2023
50 checks passed
@brookewp brookewp deleted the add/40px-size-togglegroupcontrol branch November 6, 2023 22:41
@github-actions github-actions bot added this to the Gutenberg 17.1 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants