Block Editor: Optimize 'anchor' inspector controls #55721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
Size Change: -145 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
@dcalhoun, I would appreciate your feedback if this change is okay for the mobile builds 🙇 |
dcalhoun
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #55345.
A micro-optimization for
anchorinspector controls to avoid callinguseBlockEditingModefor every block rendered in the editor and only render control when a block is selected.Why?
This control is only needed when editing a block.
How?
I tried to keep the changes to a minimum. PR extracts essential logic for the field into a separate component, only rendered when the block supports an
anchorand is selected.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast