Delete experimental radix-ui based DropdownMenu component #55626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -22.4 kB (-1%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
This was referenced Nov 17, 2023
ciampo
force-pushed
the
remove/dropdown-menu-v2-radix
branch
from
c28c14f to
baf3d7f
Compare
ciampo
added
[Type] Code Quality
ciampo
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Flaky tests detected in 59ab2c6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7291850888
|
mirka
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Do you still want to keep the Radix section in the Contributing Guide?
Otherwise, looks good 👍
Comment on lines
+18
to
+22
| DropdownMenuV2: DropdownMenu, | ||
| DropdownMenuGroupV2: DropdownMenuGroup, | ||
| DropdownMenuItemV2: DropdownMenuItem, | ||
| DropdownMenuCheckboxItemV2: DropdownMenuCheckboxItem, | ||
| DropdownMenuItemLabelV2: DropdownMenuItemLabel, |
There was a problem hiding this comment.
Aside: Not sure if I talked to you about this, but I'm thinking we should switch to dot notation exports (DropdownMenuV2.Group, etc) for better ergonomics all around. It's really cumbersome with all the unlocking and aliasing.
There was a problem hiding this comment.
Yes, I'd like to switch to dot notation too. Maybe call the "parent" component DropdownMenu.Root too. Let's discuss / address in a separate PR!
Makes sense, opened #57336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #55625
What?
Remove the experimental, temporary version of
DropdownMenubased off Radix UIWhy?
The Radix UI version is being removed in favour of the ariakit-based version (see #50459 for more details)
How?
DropdownMenuV2radix-uias a dependency of the projectDropdownMenuV2Ariakitcomponent toDropdownMenuV2(including folder structure).I recommend reviewing commit-by-commit.
Testing Instructions