Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Update Usage Example for block variation picker: Fix Import from Wrong Package #55555

Merged

Conversation

jawadmalikdev
Copy link
Contributor

What?

I updated the documentation for using the block variation picker component with the correct code.
Initially, the store was imported from the wrong package, which was @wordpress/block-editor, and it was imported as "blockEditorStore" However, in the code, it's referred to as "blocksStore"

Why?

The usage example can be confusing for users and might make it difficult for them to troubleshoot the issue. However, the problem is simply due to importing from the wrong package.

How?

I fixed the import to use the right package, which is @wordpress/blocks. I also imported the store as "blocksStore" and that's what being used in the code.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 23, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jawadhere! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@jawadmalikdev jawadmalikdev changed the title [Docs]: update block variation picker store import [Docs]: Update Usage Example for block variation picker: Fix Import from Wrong Package Oct 23, 2023
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Dec 8, 2023
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@Mamaduka
Copy link
Member

Mamaduka commented May 5, 2024

Hi, @jawadmalikdev

Do you mind rebasing this branch on top of the latest trunk? That should fix the CI checks.

Thanks!

Copy link

github-actions bot commented May 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jawadmalikdev.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jawadmalikdev.

Co-authored-by: ajitbohra <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jawadmalikdev
Copy link
Contributor Author

@Mamaduka I have rebased it on the latest trunk.

Plz have a look.

Thanks!

@Mamaduka Mamaduka merged commit 9a6b2cc into WordPress:trunk Aug 27, 2024
58 checks passed
Copy link

Congratulations on your first merged pull request, @jawadmalikdev! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 27, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
Unlinked contributors: jawadmalikdev.

Co-authored-by: ajitbohra <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants