Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dangling comma causing PHPUnit failures #55494

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

noahtallen
Copy link
Member

A small PHP syntax error (a dangling comma in a function argument list) has been causing PHPUnit failures on trunk since #53922. This fixes it :)

@noahtallen noahtallen requested review from jorgefilipecosta and removed request for spacedmonkey October 19, 2023 19:40
@noahtallen noahtallen self-assigned this Oct 19, 2023
@noahtallen noahtallen added [Type] Bug An existing feature does not function as intended [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration labels Oct 19, 2023
@noahtallen noahtallen changed the title Remove dangling comma Remove dangling comma causing PHPUnit failures Oct 19, 2023
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/sync/class-gutenberg-http-signaling-server.php

@noahtallen
Copy link
Member Author

I'll go ahead and merge this if PHPUnit tests pass.

@noahtallen noahtallen merged commit fa73f82 into trunk Oct 19, 2023
51 of 53 checks passed
@noahtallen noahtallen deleted the fix-php-syntax-err branch October 19, 2023 19:51
@github-actions github-actions bot added this to the Gutenberg 17.0 milestone Oct 19, 2023
@jorgefilipecosta
Copy link
Member

Thank you for this fix @noahtallen 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants