Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Social Icons: Ensure inactive icons are visible with block-based themes #55398

Merged
merged 9 commits into from
Oct 25, 2023
Merged

[RNMobile] Social Icons: Ensure inactive icons are visible with block-based themes #55398

merged 9 commits into from
Oct 25, 2023

Commits on Oct 16, 2023

  1. Default colors for inactive icons with block theme

    Siobhan committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    bd1c28b View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge branch 'trunk' into rnmobile/social-icon-background-dark-mode

    Siobhan committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    46500e4 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    Siobhan committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    90f8216 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into rnmobile/social-icon-background-dark-mode

    Siobhan committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ecf82a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Replace context with function for fetching styles

    Siobhan committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    dc5653a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into rnmobile/social-icon-background-dark-mode

    Siobhan Bamber authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7dc5440 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into rnmobile/social-icon-background-dark-mode

    Siobhan Bamber authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4904259 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Swap inactive icon colors with reduced opacity 

    As per the feedback here, we've decided to reduce the opacity of inactive icons, rather than setting custom colors: #55398 (comment)

This change aligns with the web's behaviour.
    Siobhan committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    bcda233 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into rnmobile/social-icon-background-dark-mode

    Siobhan committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a725f24 View commit details
    Browse the repository at this point in the history