Components: Expose Tabs as private API
#55327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
added
[Package] Components
tyxla
approved these changes
Oct 13, 2023
Comment on lines
64
to
65
| Theme, | ||
| Tabs, |
There was a problem hiding this comment.
We're intentionally keeping the Tabs. namespace because we're aiming to access the components with Tabs.TabList and Tabs.Tab right?
Co-authored-by: Marin Atanasov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Exposes the new
Tabscomponent as a private API.Why?
To experiment with
Tabsin the editor as a substitute forTabPabelimplementations, or use cases whereTabPanelwasn't suitable and custom solutions were needed instead.How?
Adding
Tabsto the package's list of private APIsTesting Instructions
All tests should pass, but no impactful changes are being made on this PR.