Add selector as id to layout style overrides. #55291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Regression
|
Size Change: 0 B Total Size: 1.65 MB ℹ️ View Unchanged
|
andrewserong
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
This is testing well for me, and the code change looks good and safe since the layout and child layout supports use different selectors 👍
There's a proposed PR (#54493) that will improve the ids used by the block supports, but since that one won't be part of 6.4, I think this will be a good fix for 6.4.
LGTM! ✨
jsnajdr
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
I'm confirming that this works for me. The base layout (flex-orientation) is added as .wp-container-1, the child layout (flex-grow) is added as .wp-container-content-1. And they no longer overwrite each other.
I'm also happy to learn some details about how styles work, I was previously very unfamiliar with this area.
Oooh nice, I missed that one somehow. Thanks for reviewing and testing folks! |
|
I just cherry-picked this PR to the 6.4-rc1-2 branch to get it included in the next release: dab99ea |
mikachan
pushed a commit
that referenced
this pull request
Oct 13, 2023
mikachan
removed
the
Backport to WP 6.7 Beta/RC
SiobhyB
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Add selector as id to layout style overrides. (#55291) * Fix flickering when focusing on global style variations (#55267) * ProgressBar: use text color to ensure enough contrast against background (#55285) * Use text color at different opacities for track and indicator * Add high contrast mode styles * CHANGELOG # Conflicts: # packages/components/CHANGELOG.md * Remove empty attrs. (#54496) * Remove empty attrs. * Fix linter errors --------- Co-authored-by: Sarah Norris <[email protected]> * Add IS_GUTENBERG_PLUGIN flag to LastRevision (#55253) * useBlockPreview: Try outputting EditorStyles to ensure local style overrides are rendered (#55288) * useBlockPreview: Try alternative fix for displaying local style overrides * Avoid duplicate styles, fix rendering issues in Safari * Add more explanatory comments * Remove additional check for styles within the block preview, as it is not needed since EditorStyles handles its own style overrides retrieval * Bug: PHP notice when an image with lightbox is deleted (#55370) * Fix PHP notice when an image with lightbox is deleted * Fix PHP notice when an image with lightbox is deleted --------- Co-authored-by: tellthemachines <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Marco Ciampini <[email protected]> Co-authored-by: Jonny Harris <[email protected]> Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: Kishan Jasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #55249.
setStyleOverride, introduced to layout in #54466, was using the same id for both layout styles and child layout styles, which sometimes coexist in the same block. As a result, adding child layout to a block that already had layout was wiping out the layout styles.This PR changes the id passed to
setStyleOverrideanddeleteStyleOverrideto the CSS selector for the styles, which ensures it won't be the same for layout and child layout.Testing Instructions
(incidentally, the control in Dimensions should show "Height" instead of "Width" for a Stack block. I'll look into that separately 😄 )