Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Backport updates from Core #55227

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Oct 10, 2023

What?

Brings over already-merged and already-accepted updates to the HTML API from Core into Gutenberg's compatability layer.

Why?

Keeps the code in sync with each other and avoids mismatches between versions.

How?

"Blessed" backport.

Testing

Please ensure that the backport files are handled properly, and that the appropriate renaming has taken place.

@dmsnell dmsnell added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup labels Oct 10, 2023
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.4/html-api/class-gutenberg-html-tag-processor-6-4.php
❔ lib/compat/wordpress-6.4/html-api/class-wp-html-processor.php

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Flaky tests detected in cf3b27f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6475244719
📝 Reported issues:

@dmsnell dmsnell changed the title HTML API: Backup updates from Core HTML API: Backport updates from Core Oct 10, 2023
 - add `has_class()` and `class_list()` methods [#59209-trac](https://core.trac.wordpress.org/ticket/59209)
 - add `matches_breadcrumbs()` method [#59400-trac](https://core.trac.wordpress.org/ticket/59400)
 - rename `createFramgent()` to `create_fragment()` [#59547-trac](https://core.trac.wordpress.org/ticket/59547)
@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core branch from 8f178ba to cf3b27f Compare October 10, 2023 21:58
@dmsnell dmsnell merged commit cf3b27f into trunk Oct 10, 2023
49 checks passed
@dmsnell dmsnell deleted the html-api/backport-updates-from-core branch October 10, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants