(WP 6.4-compat) Add missing type attribute in WP 6.4 compat's block-hooks.php

[fullofcaffeine]

What?

Add missing type attribute in WP 6.4 compat's block-hooks.php

Why?

Activating Gutenberg 16.7+ in an env with WP 6.4 is causing failures in the following test: https://github.com/WordPress/wordpress-develop/blob/36d4e7ebcc2deb9ec9de7f4ffc4161135f87d1c5/tests/phpunit/tests/rest-api/rest-block-type-controller.php, because Gutenberg does not define the type in schema for block-type and block-hooks fields in its back compat shim. Example of a failure (there are around 10 if you try running it):

Unexpected incorrect usage notice for rest_sanitize_value_from_schema.
The "type" schema keyword for  is required. (This message was added in version 5.5.0.)
Failed asserting that an array is empty.

How?

See "What".

Testing Instructions

1. Without applying this patch, Install Gutenberg 16.7 (or trunk) in a dev version of WP 6.4 with PHPUnit tests setup
2. Run https://github.com/WordPress/wordpress-develop/blob/36d4e7ebcc2deb9ec9de7f4ffc4161135f87d1c5/tests/phpunit/tests/rest-api/rest-block-type-controller.php;
3. Verify that tests fail;
4. Now build a new GB from this branch and install it in that WP 6.4 env
5. Run the test again - it should pass.

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: .

Read more about Type labels in Gutenberg.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.4/block-hooks.php

[github-actions]

Flaky tests detected in 502d671.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6435218018
📝 Reported issues:

• [Flaky Test] should insert elements from multiple completers in a single block #47916 in /test/e2e/specs/editor/various/autocomplete-and-mentions.spec.js
• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[noahtallen]

I can confirm this solves the issue.

[noahtallen]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

cc @gziolo -- since this change is required to get the core PHPUnit tests to pass, does this need to be part of the WordPress backport? I'm not exactly sure how that works with compat files

[gziolo]

since this change is required to get the core PHPUnit tests to pass, does this need to be part of the WordPress backport? I'm not exactly sure how that works with compat files

It looks like everything is looking good on the core side. Thank you for bringing the same changes to the plugin to the code that offers backward compatibility for older versions of WordPress:

https://github.com/WordPress/wordpress-develop/blob/eb0ae5679a3477c4507b09a283c05b67b87130ab/src/wp-includes/rest-api/endpoints/class-wp-rest-block-types-controller.php#L717-L729