Try to fix multi-block-selection flakiness #55075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.65 MB ℹ️ View Unchanged
|
|
Flaky tests detected in affdc92c6c0ae4743b9d7d0c2a203a45af1ffd4d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6415521804
|
|
Fine with skipping if it keeps failing. Would have loved to have a webkit e2e test though. |
kevin940726
force-pushed
the
fix/multi-block-selection-webkit-flakiness
branch
from
caa080b
to
319a57b
Compare
|
319a57b seems to fix the issue after six retries. Let's try it for the last time. |
Mamaduka
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #53564. Try to fix #53524.
Why?
The test has become really flaky for the past two months since it was introduced.
How?
.click()with nopositionoption specified will pick a visible point but not guarantee to be in the center of the element.strongTextto avoid calculating clickable points based on the parent element.Testing Instructions
CI should pass without flakiness.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A