Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add a callout to the wp-now documentation to mention it's still experimental #55044

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Docs: Add a callout to the wp-now documentation to mention it's still experimental #55044

merged 5 commits into from
Oct 4, 2023

Conversation

priethor
Copy link
Contributor

@priethor priethor commented Oct 4, 2023

What?

Update the wp-now documentation to mention it's still experimental.

Why?

So that users understand the risks involved and use it at their own risk.

How?

By adding a callout notice!

@priethor priethor added the [Type] Developer Documentation Documentation for developers label Oct 4, 2023
@priethor priethor requested a review from desrosj October 4, 2023 13:25
@priethor priethor self-assigned this Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Flaky tests detected in 94d72b7.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6408366712
📝 Reported issues:

t-hamano
t-hamano reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I would like to suggest only two changes.

docs/getting-started/devenv/get-started-with-wp-now.md Outdated Show resolved Hide resolved
docs/getting-started/devenv/get-started-with-wp-now.md Outdated Show resolved Hide resolved
desrosj
desrosj approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending the resolution of the outstanding feedback (which I agree with).

@priethor
Copy link
Contributor Author

priethor commented Oct 4, 2023

Thanks all for double-checking this, I agree with the suggestions! ✅

@t-hamano t-hamano self-requested a review October 4, 2023 15:47
@priethor priethor enabled auto-merge (squash) October 4, 2023 15:51
@priethor priethor merged commit c4e10d3 into trunk Oct 4, 2023
49 of 50 checks passed
@priethor priethor deleted the docs/add-experimantal-callout-to-wpnow branch October 4, 2023 16:28
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@desrosj desrosj desrosj approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

Assignees

@priethor priethor

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 16.8
Development

Successfully merging this pull request may close these issues.
4 participants
@priethor @desrosj @ndiego @t-hamano