Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Component: Typescript'n #54953

Merged
merged 15 commits into from
Oct 5, 2023
Merged

Text Component: Typescript'n #54953

merged 15 commits into from
Oct 5, 2023

Conversation

margolisj
Copy link
Contributor

What?

Upgrades lots of Text files to typescript.

Why?

Typescript is the only sane was to maintain a JS codebase this large.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@margolisj
Copy link
Contributor Author

@mirka @ciampo #35744. Like always, lmk if there are any other changes necessary. Cheers. Left a few TODOs in there as well at left some types less narrowed than I normally would. LMK if this was what you were looking for workwise. Cheers.

ciampo
ciampo reviewed Oct 2, 2023
View reviewed changes
packages/components/src/text/hook.ts Outdated Show resolved Hide resolved
packages/components/src/text/hook.ts Outdated Show resolved Hide resolved
packages/components/src/text/hook.ts Outdated Show resolved Hide resolved
packages/components/src/text/utils.ts Outdated Show resolved Hide resolved
packages/components/src/text/utils.ts Show resolved Hide resolved
packages/components/src/text/utils.ts Outdated Show resolved Hide resolved
@margolisj margolisj force-pushed the text-adjustLineHeightForInnerControls branch from 3aad5d0 to 8119d04 Compare October 2, 2023 15:49
@margolisj
Copy link
Contributor Author

Also, I moved the native-styles which is why the React Native tests are probably failing.

@margolisj margolisj force-pushed the text-adjustLineHeightForInnerControls branch 2 times, most recently from eb16ceb to 4fc1b75 Compare October 3, 2023 03:34
This was referenced Oct 3, 2023
Closed
Closed
Merged
@ciampo
Copy link
Contributor

ciampo commented Oct 3, 2023

We should be able wrap this up after #54953 (comment) and #54953 (comment) are addressed :)

@margolisj margolisj force-pushed the text-adjustLineHeightForInnerControls branch from ebb4751 to cab75a3 Compare October 5, 2023 00:47
ciampo
ciampo approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you for working on this

@ciampo ciampo enabled auto-merge (squash) October 5, 2023 07:11
@ciampo ciampo merged commit 830d13b into WordPress:trunk Oct 5, 2023
49 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.9 milestone Oct 5, 2023
@justintadlock justintadlock added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 16.9
Development

Successfully merging this pull request may close these issues.
3 participants
@margolisj @ciampo @justintadlock