[RNMobile] Set native extension to media upload constant file #54928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
fluiddot
changed the title
4 tasks
|
Flaky tests detected in b7d4ea5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6353040768
|
dcalhoun
approved these changes
Sep 29, 2023
Comment on lines
11
to
15
| export const OPTION_TAKE_VIDEO = __( 'Take a Video' ); | ||
| export const OPTION_TAKE_PHOTO = __( 'Take a Photo' ); | ||
| export const OPTION_TAKE_PHOTO_OR_VIDEO = __( 'Take a Photo or Video' ); | ||
| export const OPTION_INSERT_FROM_URL = __( 'Insert from URL' ); | ||
| export const OPTION_WORDPRESS_MEDIA_LIBRARY = __( 'WordPress Media Library' ); |
There was a problem hiding this comment.
In reality, these same strings are utilized elsewhere outside of tests. An alternative to relocating these might be renaming this file to constants.native.js and replacing the duplicative string literals with references to these constants.
There was a problem hiding this comment.
@dcalhoun Yeah, this would be a good alternative. Probably if we rename the file to constants.native.js the i18n script will identify these strings as native-only ones. I'll apply your suggestion and check if the verify that the i18n script works as expected.
fluiddot
force-pushed
the
rnmobile/update/media-upload-test-constants
branch
from
c96b06a to
b7d4ea5
Compare
fluiddot
changed the title
|
Hey @dcalhoun, following this comment thread , I've updated the PR with your suggestion. Let me know if you could take another look at the PR, thanks 🙇 ! |
dcalhoun
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move the test-only media upload constants to the test file where they are being used.Following this suggestion, the media upload constants file now has the native extension and the option constants are being used in the
MediaUploadcomponent.Why?
This addresses an issue when bundling Gutenberg Mobile related to missing i18n localizations (reference).
How?
The constants related to media options being used inpackages/block-editor/src/components/media-upload/test/index.native.jshave been moved from the constants file (packages/block-editor/src/components/media-upload/constants.js) to the test.packages/block-editor/src/components/media-upload/constants.jsfile has changed tonative.js.MediaUploaduses the media options constants to define the media sources displayed in the "Choose media" picker.Testing Instructions
CI jobs
Media options
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A