Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: use wporg cdn to host the google fonts json data #54795

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

matiasbenedetto
Copy link
Contributor

fix: #54685

@matiasbenedetto matiasbenedetto added Needs PHP backport Needs PHP backport to Core [Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement. labels Sep 25, 2023
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikachan mikachan added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Sep 25, 2023
@matiasbenedetto matiasbenedetto enabled auto-merge (squash) September 25, 2023 15:53
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/fonts/font-library/font-library.php

@matiasbenedetto matiasbenedetto merged commit 4a0caa5 into trunk Sep 25, 2023
52 of 55 checks passed
@matiasbenedetto matiasbenedetto deleted the fix/google-fonts-json-data-url branch September 25, 2023 16:33
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Sep 25, 2023
@mikachan
Copy link
Member

I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: e11e85e

mikachan pushed a commit that referenced this pull request Sep 26, 2023
@mikachan mikachan removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Sep 26, 2023
mikachan pushed a commit that referenced this pull request Sep 26, 2023
Mamaduka added a commit that referenced this pull request Sep 26, 2023
* use the wporg cdn (#54795)

* core-data: Fix nested property access with undefined name (#54790)

* core-data: Fix nested property access with undefined name

* Add a unit test

* Social Links: add X (#54092)

* Social Links: add X

Fixes #53223

* Add Twitter keyword to variation

This will allow people to find the new icon when searching for Twitter.

See #53223 (comment)

* Reorder links alphabetically

Co-authored-by: Aki Hamano <[email protected]>

* No need for a capital letter

Co-authored-by: Aki Hamano <[email protected]>

* Fix svg attributes

See #54092 (comment)

Co-authored-by: Rich Tabor <[email protected]>

* Remove "icon"

Co-authored-by: Nick Diego <[email protected]>

* Update X icon path

See #54092 (comment)
See #54092 (comment)

---------

Co-authored-by: Aki Hamano <[email protected]>
Co-authored-by: Rich Tabor <[email protected]>
Co-authored-by: Nick Diego <[email protected]>

* remove font files created by tests after tests run (#54771)

* Check that new pattern is synced before replacing existing blocks with a synced pattern (#54804)

* Patterns: Improve sentence case consistency of labels and notices (#54807)

* Navigation block: fix padding on mobile overlay when global padding is 0 (#53725)

* force min value for padding to be 2rem

* fallback for when the css variables are not defined

* Allow the padding to be smaller than 2rem

* Add fix to avoid trigger hover state on links when overlay opens

---------

Co-authored-by: scruffian <[email protected]>
Co-authored-by: Dave Smith <[email protected]>

* Always show the total number of patterns even with only one page (#54813)

* Always show the total number of patterns even with only one page

* Add to explorer too

* Hide total number of 0

* Font Library: Avoid rendering Font Library UI outside Gutenberg plugin (#54830)

* Remove action to fix tests. (#54806)

* Conditionally remove deprecated 'print_emoji_styles' (#54828)

* Fix Performance tests

* Fix global styles revision

---------

Co-authored-by: Matias Benedetto <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>
Co-authored-by: Jeremy Herve <[email protected]>
Co-authored-by: Aki Hamano <[email protected]>
Co-authored-by: Rich Tabor <[email protected]>
Co-authored-by: Nick Diego <[email protected]>
Co-authored-by: Glen Davies <[email protected]>
Co-authored-by: Aaron Robertshaw <[email protected]>
Co-authored-by: Maggie <[email protected]>
Co-authored-by: scruffian <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Jonny Harris <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Library: replace font preview URLs from provosional to wporg CDN URLs
3 participants