Patterns: Fix sidebar nav screen fallback category #54754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
the
[Feature] Patterns
aaronrobertshaw
requested review from
glendaviesnz,
ramonjd and
kevin940726
aaronrobertshaw
added
the
[Type] Code Quality
|
Size Change: +36 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
glendaviesnz
added
the
Backport to Gutenberg RC
|
Thanks for the sleuthing and communication. LGTM |
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 142551d |
mikachan
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Fixes the fallback category type to match the category prior to the constants refactor.
Given the check within the
PatternCategoriesGroupthe incorrect value didn't change final behaviour, this is to avoid future headachesWhy?
When getting to merging all types of patterns (template parts, user patterns, themes etc.) it will be easier to reconcile if the default pattern and fallbacks all match.
How?
Corrects the fallback for the current category type to match what it was before the constants refactor.
Testing Instructions
DEFAULT_TYPEagainDEFAULT_TYPEvalue