Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: UI updates for the image lightbox (redo) #54509

Merged
merged 93 commits into from
Sep 15, 2023

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    08bb1ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c93f1b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25aa1c6 View commit details
    Browse the repository at this point in the history
  4. Restructured use of global behaviors

    Simplified the `__experimentalUseGlobalBehaviors` function by removing the 'source' parameter. Now, the function directly uses 'userConfig' for getting raw data and 'mergedConfig' for variable value.
    michalczaplinski committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a8c09c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Configuration menu
    Copy the full SHA
    fac2e3a View commit details
    Browse the repository at this point in the history
  2. Remove the reference to behaviors in Global styles and first iteratio…

    …n of updates to the lightbox UI
    michalczaplinski committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    dfc1c46 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    51e4802 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Configuration menu
    Copy the full SHA
    b416558 View commit details
    Browse the repository at this point in the history
  2. Adjust schema properties count assertion

    Previously, the test was checking whether schema properties array had exactly 10 elements
    We're now checking for exactly 9 elements instead.
    michalczaplinski committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    321a213 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e613a5b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0021116 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6951a86 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b0fb3b5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b76d56c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Configuration menu
    Copy the full SHA
    1872f77 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cfcb15 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2818af View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. Configuration menu
    Copy the full SHA
    a32d0f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e67634e View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Refactor image settings panel and screen block

    Simplified the ImageSettingsPanel and ScreenBlock components. More specific changes:
     - Removed `name` and `settings` from the ImageSettingsPanel
     - Use `userSettings` instead of `settings` in the ImageSettingsPanel
     - Modified `onChangeLightbox` logic, it now takes a new setting instead of a boolean and directly passes to `onChange`
     - Updated the ScreenBlock component to account for this refactor
    michalczaplinski committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    3ddb1b1 View commit details
    Browse the repository at this point in the history
  2. Add showUI option to lightbox settings

    A new option has been added to the lightbox settings in the Theme JSON reference guide and Gutenberg class. This `showUI` option allows users to toggle whether the Lightbox UI is displayed in the block editor or not. Also, updated the JSON schema accordingly to reflect these changes in theme.json files.
    michalczaplinski committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    fae6f99 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df9f857 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df3f1c6 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Add filters; add legacy support for behaviors syntax

    I moved the logic to determine whether the lightbox should display
    or not to two render_block_data filters.
    
    One of these filters is inside of the index.php
    so that itc can exist in WP core, the other inside of blocks.php
    in order to offer legacy support for the Behaviors syntax in
    the Gutenberg plugin.
    
    Using the render_block_data instead of render_block allows us to
    store a 'lightboxEnabled' value on the block, which we can use to
    determine whether the lightbox should be rendered in these two
    separate locations relatively cleanly without needing to touch
    the markup.
    
    I added behaviors back to the valid top-level keys so that we can
    read it to offer legacy support.
    
    Lastly, I set the lightbox.enabled attribute to NULL by default
    so that we can determine whether the Behaviors syntax should override
    it or not.
    artemiomorales committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    075535b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2a0b3f View commit details
    Browse the repository at this point in the history
  3. If no value is set for the lightbox in the Global Styles, then the bl…

    …ock editor UI should inherit the value from `theme.json`.
    
    Likewise, if no value is set in the block attributes, the block editor UI should inherit the value from the Global Styles of the Image.
    michalczaplinski committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    91d130c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c58612c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c602139 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    339a715 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Configuration menu
    Copy the full SHA
    4b43b30 View commit details
    Browse the repository at this point in the history
  2. Fix PHP linter errors

    artemiomorales committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ce3c338 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92b084f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7fefb83 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    03e60d7 View commit details
    Browse the repository at this point in the history
  6. Empty commit

    michalczaplinski committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    050c636 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    521d950 View commit details
    Browse the repository at this point in the history
  2. Add deprecation notice for 'behaviors' in image block

    I needed to add 'behaviors' back to the block.json attributes
    in order to read them on the JavaScript side in the editor
    to fire the deprecation notice.
    artemiomorales committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    1db73c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    232161a View commit details
    Browse the repository at this point in the history
  4. Do not remove behaviors attribute from Image block's block.json.

    Behaviors are deprecated for 2 more releases and will be removed then.
    michalczaplinski committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    cabe31b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    715e32c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aa4450e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    41f251d View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Configuration menu
    Copy the full SHA
    79dad34 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Configuration menu
    Copy the full SHA
    871ba45 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Configuration menu
    Copy the full SHA
    7f2f70f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6da3545 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91b86ef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    83bef30 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    52e358d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    11e96e2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8809612 View commit details
    Browse the repository at this point in the history
  8. Copy class-wp-theme-json-schema.php from core

     into `class-wp-theme-json-schema-gutenberg.php`
    michalczaplinski committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    59e0dbe View commit details
    Browse the repository at this point in the history
  9. Merge branch 'update/lightbox-settings-panels' of github.com:WordPres…

    …s/gutenberg into update/lightbox-settings-panels
    michalczaplinski committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    3eeb1a7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f9e48f4 View commit details
    Browse the repository at this point in the history
  11. Add a theme.json migration to v3 away from behaviors and to a new, si…

    …mpler syntax used by the lightbox.
    michalczaplinski committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    443aa5b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6459d56 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    203649d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    5a37499 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0e63890 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    8b721a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8287c46 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2c2b94 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f0709b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7018ee7 View commit details
    Browse the repository at this point in the history
  6. Resolve lint error

    artemiomorales committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7fd0801 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5bb05bc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a02910c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b12d386 View commit details
    Browse the repository at this point in the history
  10. Add support for reading top-level 'lightbox' setting in editor

    By default, we read the lightbox settings underneath the 'core/image'
    in theme.json; however, the 'enabled' property there is undefined by default,
    which means it should be possible to declare a top-level setting for the lightbox
    that overrides an undefined block-level setting.
    
    While this appeared to be working on the PHP side, the UI wasn't accurately
    reflecting this inheritance structure, so this commit fixes that.
    
    Users should now be able to define a top-level lightbox setting as either
    'lightbox: true' or 'lightbox: { enabled: true }' that will be used
    if the block-level lightbox setting for 'enabled' is undefined.
    artemiomorales committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2f5f122 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Configuration menu
    Copy the full SHA
    a238d94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0aba3c4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8fa991e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    65b173c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b5f8186 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7e121da View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fb10384 View commit details
    Browse the repository at this point in the history
  8. Remove inheritance when determining whether to enable lightbox

    Rather than trying to check if the 'enabled' has been set or not
    and falling back to other levels of the theme.json inheritance
    structure, I decided to just read and use the settings as defined
    in theme.json. This is the expected behavior in Gutenberg from
    what I understand and has less edge cases.
    artemiomorales committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ef8f43e View commit details
    Browse the repository at this point in the history
  9. Update comment

    artemiomorales committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    fc8fc47 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Update whitespace in theme.json

    Co-authored-by: Alex Lende <[email protected]>
    michalczaplinski and ajlende authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6ea39f8 View commit details
    Browse the repository at this point in the history
  2. Add docblocks to clarify that `class-wp-theme-json-schema-gutenberg.p…

    …hp` is only put in GB as a temporary migration.
    michalczaplinski committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    aaab1ef View commit details
    Browse the repository at this point in the history
  3. Add comments to clarify that behaviors.php is temporarily added to GB…

    … an will be removed in a future version.
    michalczaplinski committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    61bfb3d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c18e283 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8b95f4a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7d30aa6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dab7f5a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a5c2f0c View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Configuration menu
    Copy the full SHA
    485c197 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1432bc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ff1d2b5 View commit details
    Browse the repository at this point in the history
  4. Remove 'lightbox' from hooks.js and add .enabled & .allowEditing

    …to class-wp-theme-json-gutenberg.php
    michalczaplinski committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ee1dd8c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c30fd60 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1ffe40b View commit details
    Browse the repository at this point in the history
  7. Fix phpcs error

    artemiomorales committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    8586f29 View commit details
    Browse the repository at this point in the history