Followup to #54206 #54419
Merged
Followup to #54206 #54419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just missing suggestions for |
|
Size Change: +52 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
Thanks @Mamaduka! |
Mamaduka
approved these changes
Sep 13, 2023
|
Flaky tests detected in 8457a87. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6171753269
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a followup to #54206 with code improvements that came in a review after the PR was merged
Why?
Minor code-quality improvements
How?
isLinkTagconst to avoid code duplicationisButtonTagconst to avoid code duplicationenumto thetagNamedefinition inblock.jsonTesting Instructions
Nothing to test. If automated tests pass, we're OK.
Testing Instructions for Keyboard
Nothing to test.