[Do not merge] Update block settings menu to use a controlled dropdown menu component #54236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is open at a time
Co-authored-by: Ramon <[email protected]>
|
Size Change: +229 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
🚧 🚧 🚧 🚧 This PR is forked from #54083 as an experiment, it is not intended to land 🚧 🚧 🚧 🚧
This PR is exactly the same as #54083 except that it attempts to use a controlled component. Unfortunately, it doesn't quite appear to be viable to use this approach, but I thought I'd push this PR for visibility so that we can compare it to #54083 when evaluating approaches
Why?
To explore feedback in #54083 (review), and to hone in on a good solution.
How?
See the implementation in 67801dd
Testing Instructions
Note: in the current state of this PR, it's buggy as shown in the screengrab below.
Screenshots or screencast
Buggy current state:
2023-09-07.13.49.10.mp4