Prevent the list view shortcut from typing unexpected characters #54078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Aug 31, 2023
There was a problem hiding this comment.
I have checked the shortcut in trunk and there seems to be no problem in the Windows 11 environment. Does this problem occur only on Mac OS? Also, does this shortcut add any visible Unicode characters?
Incidentally, I have confirmed that this PR change will not cause any new problems in the Windows environment for both Chrome and Firefox.
youknowriad
added
the
Browser Issues
It occurs for me in Safari MacOS. Not in Chrome. listview.mov |
t-hamano
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
From what I have found, the problem seems to be related to Unicode Input. If so, it may be that the Gutenberg shortcuts conflict with the Unicode Input key combinations.
In any case, if it is a shortcut for switching panels, I think it would make sense to prevent the default event.
|
Thanks for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In trunk, if the "post title" input is focused in the post editor and I hit the "open list view" shortcut (access + o, alt + ctrl + o), the list view opens but there's a weird unicode character that gets also inserted into the post title. This PR fixes that by preventing the default event behavior.
Testing Instructions
1- Open the post editor
2- Focus the post title input
3- Hit Alt + Ctrl + o to open the list view
4- The list view should open without writing a random character on the post title input.