-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent the list view shortcut from typing unexpected characters #54078
Conversation
Size Change: +3 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the shortcut in trunk and there seems to be no problem in the Windows 11 environment. Does this problem occur only on Mac OS? Also, does this shortcut add any visible Unicode characters?
Incidentally, I have confirmed that this PR change will not cause any new problems in the Windows environment for both Chrome and Firefox.
It occurs for me in Safari MacOS. Not in Chrome. listview.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I have found, the problem seems to be related to Unicode Input. If so, it may be that the Gutenberg shortcuts conflict with the Unicode Input key combinations.
In any case, if it is a shortcut for switching panels, I think it would make sense to prevent the default event.
Thanks for the review :) |
What?
In trunk, if the "post title" input is focused in the post editor and I hit the "open list view" shortcut (access + o, alt + ctrl + o), the list view opens but there's a weird unicode character that gets also inserted into the post title. This PR fixes that by preventing the default event behavior.
Testing Instructions
1- Open the post editor
2- Focus the post title input
3- Hit Alt + Ctrl + o to open the list view
4- The list view should open without writing a random character on the post title input.