Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Group blocks in the Editor via Modal #53735

Merged
merged 38 commits into from
Sep 1, 2023
Merged

Rename Group blocks in the Editor via Modal #53735

merged 38 commits into from
Sep 1, 2023

Commits on Sep 1, 2023

  1. Enable metadata support for Group block

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9196ff8 View commit details
    Browse the repository at this point in the history

  2. Enable Rename option in block dropdown

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    d3896d0 View commit details
    Browse the repository at this point in the history

  3. Add rename functionality via modal

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    13b330a View commit details
    Browse the repository at this point in the history

  4. Use pretty block name as default

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5d3da47 View commit details
    Browse the repository at this point in the history

  5. Ensure modal cannot be shown if block does not support naming

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    d147550 View commit details
    Browse the repository at this point in the history

  6. Use aria-disabled

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    c6e227f View commit details
    Browse the repository at this point in the history

  7. Use form submit

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    ebb61ca View commit details
    Browse the repository at this point in the history

  8. Allow flow to reset custom name and remove metadata

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    0131170 View commit details
    Browse the repository at this point in the history

  9. Ensure input has label

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    09bf70a View commit details
    Browse the repository at this point in the history

  10. Scaffold initial e2e test

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    fc65b10 View commit details
    Browse the repository at this point in the history

  11. Test ability to reset value

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2611bc9 View commit details
    Browse the repository at this point in the history

  12. Leave options menu in place on modal open 

    Ensures focus transfer
    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    be32001 View commit details
    Browse the repository at this point in the history

  13. Augment tests with assertions on focus management

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    4f6bf57 View commit details
    Browse the repository at this point in the history

  14. Use provided setAttributes

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    debd5c2 View commit details
    Browse the repository at this point in the history

  15. Extract single component

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    80283bd View commit details
    Browse the repository at this point in the history

  16. Remove redundant comments

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e64e233 View commit details
    Browse the repository at this point in the history

  17. Remove redundant class

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    385f877 View commit details
    Browse the repository at this point in the history

  18. Utilise built in Playwright enabled/disabled

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b7104ac View commit details
    Browse the repository at this point in the history

  19. Use built in assertions

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    bb40a87 View commit details
    Browse the repository at this point in the history

  20. Use aria- attributes on menu item

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    c8419aa View commit details
    Browse the repository at this point in the history

  21. Autofocus input

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    036e2ec View commit details
    Browse the repository at this point in the history

  22. Add block rename to block inspector controls

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    ccf3485 View commit details
    Browse the repository at this point in the history

  23. Move information on saving block data to parent

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3acf7e5 View commit details
    Browse the repository at this point in the history

  24. Make Rename component simpler

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    82aa47b View commit details
    Browse the repository at this point in the history

  25. Use canonical block name as placeholder

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    211109b View commit details
    Browse the repository at this point in the history

  26. Add aria-described by to Modal 

    As per #53735 (comment)
    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f64ec14 View commit details
    Browse the repository at this point in the history

  27. Use custom name in List View aria label 

    Addresses #53735 (review)
    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3f5f3f1 View commit details
    Browse the repository at this point in the history

  28. Add announcement when updating the block name

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e950886 View commit details
    Browse the repository at this point in the history

  29. Default value should be empty unless custom name is set

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    530c93b View commit details
    Browse the repository at this point in the history

  30. Fix tests

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    78720ce View commit details
    Browse the repository at this point in the history

  31. Enable submitting empty to reset

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    390bfdc View commit details
    Browse the repository at this point in the history

  32. Combine e2e tests into single test to save resources

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8986386 View commit details
    Browse the repository at this point in the history

  33. Rename inspector control to Block name

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    4c70765 View commit details
    Browse the repository at this point in the history

  34. Remove required and allow submitting true empty values

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    a0243fa View commit details
    Browse the repository at this point in the history

  35. Update code to treat empty value as trigger to “reset”

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3509d1b View commit details
    Browse the repository at this point in the history

  36. Centralise assignment of blockTitle

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    fd67465 View commit details
    Browse the repository at this point in the history

  37. Add test coverage for List View reflecting custom name

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    a643e97 View commit details
    Browse the repository at this point in the history

  38. Update modal title to match menu option

    @getdave
    getdave committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    39fe73a View commit details
    Browse the repository at this point in the history