Refactor latest content selectors in 'CopyContentMenuItem' components #53676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -4 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Hey, @jorgefilipecosta, do you mind double checking this refactoring? Thanks 🙏 |
stokesman
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
I've tested and the “Copy all blocks” menu item works as expected in both the Post and Site editors and avoids the console warning. 🚢
This served as a good reminder for me of the succinct form of useSelect. Wish I’d seen this earlier and I would have avoided some effort in #53833 😅.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Discovered while working on #53666.
This is similar to #53672.
PR refactors the latest content selectors in the 'CopyContentMenuItem' components to avoid returning a callback from the
useSelecthook.Why?
The
mapSelectreturns a new callback value on every call, and this can lead to unnecessary rerenders.Testing Instructions
Confirm "Copy all blocks" feature works as before in post and site editors.
Screenshots or screencast