Components: Move accent colors to theme context #53631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
mirka,
chad1008,
ntsekouras,
brookewp and
t-hamano
|
Size Change: +13 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c2b3e70. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5864668255
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR renames the accent color values to be declared in theme context.
Why?
We're moving towards utilizing the components theming system more broadly, and that's a step in that direction. See #53347 (comment) for more details and motivation.
How?
We're basically renaming:
COLORS.ui.themetoCOLORS.theme.accentCOLORS.ui.themeDark10toCOLORS.theme.accentDarker10Testing Instructions
Verify there are no visual changes and all checks are green.
Testing Instructions for Keyboard
None
Screenshots or screencast
None