Patterns: add delete_posts to the wp_block (patterns) capabilities

[ramonjd]

Maybe resolves #53367

What?

Adds delete_posts to the wp_block (patterns) capabilities.

WordPress core backport PR:

• wp_block post type: add delete_posts to capabilities. wordpress-develop#4987

Why?

It's currently not possible to delete draft posts. The wp_block post type has delete_published_posts in the capabilities array only.

See: https://github.com/WordPress/wordpress-develop/blob/444bdf49bc38883f603a584bcc119aedf98257b8/src/wp-includes/post.php#L322

How?

Using the register_{$post_type}_post_type_args hook.

Testing Instructions

1. Add a pattern in the post editor (wp-admin/edit.php?post_type=wp_block)
2. Save it in draft status
3. Go back to the list table
4. Try to trash the pattern (the row action will not be there)

Screenshots or screencast

Before

2023-08-08.14.13.56.mp4

After

2023-08-08.14.14.24.mp4

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.4/blocks.php
❔ lib/load.php

[aaronrobertshaw]

Thanks for the fix here @ramonjd 👍

✅ Could replicate original issue
✅ Applying this PR allows deletion of draft pattern

I only had one minor question that I left via an inline comment. Pending that though, I'm happy to approve this.

Before	After

[ramonjd]

I tried to add tests for this PR, but for some reason current_user_can( 'delete_post', $draft_wp_block_id ) returns true all the time. But not here in core. 🤷🏻

Maybe something I'm missing in the way that the admin page works in this context.