Image block: Fix aspect-ratio with max-width #53250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
|
Size Change: +27 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 412eebb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5732322024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
height: 'auto'in image block save.aspect-ratiowhenever bothwidthandheightare set.heightis set andwidthis cleared? *object-fitalways be set in the case where the natural aspect ratio matches the calculated aspect ratio?What?
Always use
widthandaspect-ratioto define image block layout. * See TODOWhy?
Fixes #52739
The
max-width: 100%had unintended side-effects whenheightandwidthwere added to the inline style in #52286.Users probably expect the ratio the configure their image to be to be maintained under the effects of
max-width: 100%.How?
height: 'auto'in image block save.aspect-ratiowhenever bothwidthandheightare set.Testing Instructions
TODO
The properties to consider for layout in the existing image block are:
Various combinations of these properties that can be achieved in the editor should be considered.
Testing Instructions for Keyboard
Screenshots or screencast