Snackbar design and motion improvements #53248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +92 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Solid improvements, thank you.
The backdrop-filter is blink-and-you'll-miss-it subtle, and I wonder if it has a performance impact; if yes perhaps it's okay to omit that. But I'm happy to try this.
Probably separate since it's also an issue in trunk, but in the site view, the snackbar sits a bit high; perhaps that's because the footer gets hidden there? 🤔
Related to #53198. There's no logic to determine where snackbars start visually, with or without breadcrumbs/UI. |
richtabor
changed the title
richtabor
force-pushed
the
try/snackbar-design
branch
from
cc24469 to
059fbfe
Compare
|
Flaky tests detected in 059fbfe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5825168423
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Trying some ideas on how to improve the visual, and interaction, of snackbars by:
Why?
While touching up command palette and adding new commands, I started exploring how we could leverage snackbar notifications better in certain commands.
Per that relationship, it's a good time to coordinate improvements along this front as well.
How?
Testing Instructions
Screenshots or screencast
Before:
CleanShot.2023-08-01.at.13.37.41.mp4
After:
CleanShot.2023-08-01.at.13.38.36.mp4