Block Library: Set freeform handler only if Classic block exists #52936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
mcsf,
Mamaduka,
youknowriad,
getdave,
mtias,
jsnajdr and
flootr
|
Size Change: +518 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Thanks again for your effort on this. Using this PR, I'm not able to reproduce the freeform error in both my test case plugin or in my extended plugin (that my test-case is based off of and contains several more blocks) . Upon the gutenberg plugin's activation, I receive the notice Looking at my debug log, it's just the following; which may be fixed in #52935 ? This may be fixed in #52935 ? |
jsnajdr
approved these changes
Jul 26, 2023
|
Flaky tests detected in ec67e05. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5666046872
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the block library to set the freeform content handler to the classic block only if the classic block actually exists.
This PR is part of the fix to address #52811.
Why?
With this additional check, the freeform content handler will not be set if the TinyMCE removal experiment is turned on and the Classic block is intentionally not registered.
That way, the empty whitespaces won't be parsed to empty freeform blocks.
How?
We're just specifically setting the freeform content handler to the classic block only if the classic block actually exists.
Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None