Add 'View site' action to 'Site updated' snackbar #52693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +83 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I could see this, but I'm not entirely sure we want to add this to the snackbar. Working through it, the snackbar persists between both edit and site views, and in both those views we have these two: 
Among the above three, there's likely some further consolidation we can do, as both the edit view toolbar evolves, and as the site editor evolves. The main issue with snackbars right now is that they persist for a much too long time. They even stack endlessly, so in some cases you'll end up with a stack of 5 or 6 snackbars that still linger on screen as you're just working through editing content, templates, and styles. We have to cut back on that, both by throttling (so you only ever see at most 2, perhaps 3 snackbars stacked), but also the time these linger on screen. Last I revisited the PRs that extended the time these stayed on screen, the argument was that they contained important information, and I believe the "view post" link was specifially mentioned. To me that's an argument to embrace the permanent buttons for those actions, and actually consider removing those actions from the snackbars — keep them as ephemeral as they need to be in order for them to be able to fade out in a reasonable amount of time (closer to something like two seconds instead of the current ten seconds). I recognize we can probably refine the component further, so that for example snackbars that do not feature any actions fade out quickly, and snackbars that do feature actions can stay for a bit longer, but even in that case I would only ever put "fine to miss" actions there, and still fade them out aggressively. If we truly deeply want a snackbar to linger, they should not fade out at all, and require dismissal using an X. That's a roundabout way of saying, perhaps it's best to keep this one ephemeral? Not a strong opinion, even if my opinion on fading out snackbars quickly is :) |
I think we should. "View $postType" is available on the snackbar when publishing within the post editor. I always expect the same within the site editor. Snackbars do need revisiting in general, but from my POV publishing and clicking the "View post" link is a super helpful flow to quickly see the front-end. You don't have to find the externalLink icon, or other links to the front-end, it's presented to you. |
|
I agree with pretty much everything you said @jasmussen, but unless we intend to remove actions altogether it seems mostly separate to this particular PR. Like @richtabor said this is about surfacing the action in a relevant moment and aligning with similar Snackbars in the post editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a 'View site' action to the 'Site updated' snackbar in the site editor.
Why?
This seems like a moment where the user may want to view their changes on the frontend.
Testing Instructions