Filter to switch from the Interactivity API to the old implementation #52580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Block] File
|
@SantosGuillamot, I'd appreciate your review to make sure I didn't miss anything. Thanks 🙂 |
|
Closing as duplicate of @westonruter's #52579. |
westonruter
reviewed
Jul 12, 2023
| @@ -471,7 +471,7 @@ function render_block_core_navigation( $attributes, $content, $block ) { | |||
| // - we don't have a relationship to a `wp_navigation` Post (via `ref`). | |||
| // ...then create inner blocks from the classic menu assigned to that location. | |||
| if ( | |||
| defined( 'IS_GUTENBERG_PLUGIN' ) && IS_GUTENBERG_PLUGIN && | |||
| apply_filters( 'gutenberg_block_core_navigation_use_interactivity_api', true ) && | |||
There was a problem hiding this comment.
Is this right? The code in here is not all related to Interactivity API.
There was a problem hiding this comment.
You're right, but let's use your PR instead: #52579
|
Flaky tests detected in d762b95. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5534847419
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add filters to switch from the Interactivity API to the old implementation of the Navigation and File blocks.
Follow up on #52553.
Why?
To be able to keep improving those versions, which are still in WP Core (more context).
How?
Just replace the
IS_GUTENBERG_PLUGINconstant which was used to avoid merging the Interactivity API in Core with two filters, one for each block:gutenberg_block_core_navigation_use_interactivity_apigutenberg_block_core_file_use_interactivity_apiTesting Instructions
aria-expandedswitching totrueon hover).micromodal(check the network tab or accessibility issues likearia-expandednot switching totrueon hover).