Fix flaky Site Editor pages e2e test #52283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Jul 4, 2023
| @@ -78,7 +78,7 @@ test.describe( 'Pages', () => { | |||
| ).toBeVisible(); | |||
|
|
|||
| // Switch to template editing focus. | |||
| await page.getByRole( 'button', { name: 'Settings' } ).click(); | |||
| await editor.openDocumentSettingsSidebar(); | |||
There was a problem hiding this comment.
It's unrelated to the fix, but it's better to use the util to avoid accidentally closing the 'Settings' sidebar if it is open.
|
Thanks for testing, @tyxla! |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
Thanks @Mamaduka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed this test failing on the trunk due to the broad scope locator - https://github.com/WordPress/gutenberg/actions/runs/5453941422/jobs/9923411345.
Why?
It turns out we're always rendering the "Navigation" region in the site editor, and it also can have a "Back" button.
How?
A better-scoped "Back" button locator.
Testing Instructions