Page List: Fix ESLint warnings #52267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
draganescu and
scruffian
and removed request for
tellthemachines
Mamaduka
added
[Type] Code Quality
|
Size Change: -5 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fb4aa50. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5450859521
|
ntsekouras
reviewed
Jul 4, 2023
| const getBlockList = ( parentId = parentPageID ) => { | ||
| const childPages = pagesByParentId.get( parentId ); | ||
| const pagesTree = useMemo( | ||
| function makePagesTree( parentId = 0, level = 0 ) { |
There was a problem hiding this comment.
That's not from this PR, but it's a bit weird to see the function declaration inside useMemo. Can't we declare the function outside the components?
There was a problem hiding this comment.
As long as it's valid JS, I don't see a problem :)
There was a problem hiding this comment.
Lets fix this in a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes the ESLint warning inside the Page List block's edit component.
How?
I moved the function definition inside the
useMemohook.Testing Instructions
Confirm page list is rendered as before.