Patterns: Remove ability for user to toggle sync status after pattern creation in 16.1 release #52230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Feature] Patterns
aaronrobertshaw
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
This will be a good addition to round out the 16.1.1 point release, thanks @glendaviesnz 👍
✅ The PostSyncStatus toggle has been replaced when editing the wp_block post type.
✅ Code matches the latest on trunk
| Before | After |
|---|---|
 |
 |
 |
 |
|
Size Change: -59 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
92 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Backports removing the ability for users to toggle the sync status of a pattern once it is added to 16.1.1
Why?
Changing the sync status after the pattern has already been inserted into posts could have unexpected results. See this comment for more details.
Fixes: #51920
How?
Removes the sync toggle from the
wp_blockCPT update page.Testing Instructions
/wp-admin/edit.php?post_type=wp_blockand edit both typesScreenshots or screencast
Before:
After:
