Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue gardening automation with new label #52173

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

priethor
Copy link
Contributor

What?

Changes the 180-day automatic check to add a new Needs check-in label instead of adding the Needs testing label.

Why?

For clarity. The reason is two-fold:

  • Most inactive issues don't need testing per sé, as they are proposals or tracking issues.
  • There is another automation that marks Needs testing issues as Stale after 30 days, too, and we can end up with too many issues with both labels that we don't want to actually close or test, creating more noise and work.

How?

By using a different label that doesn't trigger the Stale issue automation.

@priethor priethor added the [Package] Project management automation /packages/project-management-automation label Jun 30, 2023
@priethor priethor requested a review from desrosj June 30, 2023 12:27
@priethor priethor requested review from bph and mrfoxtalbot July 11, 2023 09:40
@bph
Copy link
Contributor

bph commented Jul 12, 2023

That an interesting approach!
What would the expected next.step after the label is applied and by whom?

@priethor
Copy link
Contributor Author

The new label can be used to identify issues where pinging the author, and participants is necessary. That is the same use-case intended by currently adding Stale, with the difference that Stale nug reports originated by Needs testing can usually be closed, whereas inactive feature request issues can be open even for years until the functionality is implemented.

@mrfoxtalbot
Copy link

This is a great idea and it will make it easier to review and close issues that have petered out. Thank you @priethor !

@priethor
Copy link
Contributor Author

Tagging @annezazu , @jordesign and @ndiego in relation to #52583

@jordesign
Copy link
Contributor

Look great to me.

@priethor priethor merged commit e7b7f01 into trunk Jul 17, 2023
@priethor priethor deleted the priethor-update-issue-gardening-automation branch July 17, 2023 11:52
@github-actions github-actions bot added this to the Gutenberg 16.3 milestone Jul 17, 2023
westonruter added a commit that referenced this pull request Jul 18, 2023
* trunk: (36 commits)
  Use `_get_block_template_file` function and set $area variable. (#52708)
  Change Delete page menu item to Move to trash. (#52641)
  Search block: Enqueue view script through block.json (#52552)
  Patterns: fix bug with Create Patterns menu not showing in site editor page editing (#52671)
  Github workflow: add a PHP backport changes action (#52096)
  Add layout API documentation. (#52673)
  Show uncategorized patterns on the Editor > Patterns page (#52633)
  Patterns: Remove `reusable` text from menu once rename hint has been dismissed (#52664)
  Update locked pattern tooltips (#52497)
  Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save (#52682)
  Use posts instead of template parts for navigation color tests (#52654)
  Site Editor: Don't allow creating template part on the Patterns page for non-block themes (#52656)
  Site Editor: Fix incorrect 'useSelect' usage (#52683)
  Update issue gardening automation with new label (#52173)
  i18n: Make the tab labels of `ColorGradientSettingsDropdown` component translatable (#52669)
  Post Content link color should not be applied to placeholder component links (#52367)
  [Mobile] Update toolbar icons and colors (#52336)
  Avoid copying global style presets via the styles compatibility hook (#52640)
  Show warning on removal of Post Template block in the site editor. (#52666)
  Backport tools: sort PRs to be cherry picked by merged/closed date (#52667)
  ...
@priethor priethor added the [Type] Project Management Meta-issues related to project management of Gutenberg label Jul 20, 2023
@priethor priethor removed the [Package] Project management automation /packages/project-management-automation label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants