Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try restoring the site editor animation #51956

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Try restoring the site editor animation #51956

merged 9 commits into from
Jul 4, 2023

Commits on Jun 27, 2023

  1. Try restoring the site editor animation

    @talldan
    talldan committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    cf0be29 View commit details
    Browse the repository at this point in the history

  2. fix header animation

    @SaxonF
    SaxonF committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    af387c5 View commit details
    Browse the repository at this point in the history

  3. Remove accidental addition of layout prop

    @talldan
    talldan committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    9d8f62b View commit details
    Browse the repository at this point in the history

  4. tidy up formatting

    @talldan
    talldan committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e1274aa View commit details
    Browse the repository at this point in the history

  5. fix animate presence issue

    @SaxonF
    SaxonF committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2425841 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'try/restore-site-editor-animation' of https://github.co… 

    …m/WordPress/gutenberg into try/restore-site-editor-animation
    @SaxonF
    SaxonF committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7fa2fdc View commit details
    Browse the repository at this point in the history

  7. Fix animation between sidebar view and distraction free edit view

    @jeryj
    jeryj committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    3645aef View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Leave sidebar present and maintain canvas to 

    sidebar animation

The sidebar is necessary for routing on mobile so we have to maintain its presence in the DOM. Just hiding it isn't enough though, as it is still able to be reached with keyboard tabs and screen readers. Using the relatively new `inert` property disables the element from user interaction, so we add that when we don't want the sidebar to be shown.
    @jeryj
    jeryj committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    828f2da View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Fix mobile view for pattern library 

    On Mobile, the canvas mode wasn't being set to edit when using the pattern library. This updates it to use the showSidbar value instead, keeping it in sync with the inert setting.
    @jeryj
    jeryj committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b91069e View commit details
    Browse the repository at this point in the history