Restore sidebar in focus mode on Pattern click through in Browse Mode Library
#51897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Regression
getdave
requested review from
scruffian,
talldan,
kevin940726 and
aaronrobertshaw
|
Size Change: +4 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jun 27, 2023
My understanding is this wasn't the flow when the design video for the library was shared. That design was what we worked towards but it appears that before the library landed the navigation editing work changed the flow to always go via view mode. I don't have any strong feelings towards this. Each pattern in the library went to edit mode simply due to consistency with how it originally worked and the design. The navigation editing feature in the sidebar does present a valid reason to switch the patterns to go via view mode. |
getdave
added
Backport to WP 6.7 Beta/RC
|
@aaronrobertshaw Yeh it seems like there was some inconsistency in the designs around Library and Navigation sections. All good 👍
I agree. If later we find it's mostly ending up as a blank sidebar (and that's deemed a problem) we can conditionalise this based on whether there is a Navigation in the pattern. |
|
I'm going to wait on someone from @WordPress/gutenberg-design to approve / merge this one as @jameskoster has specifically tagged it. |
|
This looks good to me. Before:
After:
|
|
For template parts – specifically headers – the details panel can be useful to see in this flow. The trade-off is that general template part and reusable block details panels are essentially empty: 
Which makes traversing them a little tedious. I suspect that's why the original design called for them to be skipped. It's not a blocker, but it would be nice to display some information in that panel. Author, usage, sync status, category, etc. |
There are some minor updates in the pipeline on that front: #51954 |
jameskoster
approved these changes
Jun 27, 2023
|
I just cherry-picked this PR to the release/16.1 branch to get it included in the next release: 8256ef9 |
ramonjd
removed
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the add/pre-beta1-bugfixes branch to get it included in the next release: 1bea96c |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
added a commit
that referenced
this pull request
Jun 28, 2023
* Restore sidebar in focus mode on Pattern click through in Browse Mode Library (#51897) Brings back #51492 * [Command center]: Add preferences and keyboard shortcuts commands (#51862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels * [Site Editor]: Fix `library` command path (#51837) * Updating social link attributes (#51997) * Try: Update template titles (#51428) * Update template titles * Fix typo Co-authored-by: Alex Stine <[email protected]> * Revert Index rename * "front page" -> "homepage" * Update 404 Page make more sense given the template appears in the Pages panel too. * Front Page * home title + description * Revert Home name change, and move compat files * separate code for wp versions * update tests --------- Co-authored-by: Alex Stine <[email protected]> Co-authored-by: ntsekouras <[email protected]> * Update text color (#51965) * Modal: Add small top padding to the content so that avoid cutting off the visible outline when hovering items (#51829) * Site Editor: Fix focus cutoff in add template modal * Add padding-top to the modal content * Remove unnecessary padding-top * Remove unnecessary padding-top * Update changelog * Revert top padding from block patterns list * Revert top padding from block patterns list * Remove unnecessary changes * Remove unnecessary changes * Add CSS inline comment * Change padding metrics * Rest API: rename navigation fallback classes from WP_ to Gutenberg_ (#51959) * The `WP_REST_Navigation_Fallback_Controller` class has been committed to core and therefore results in a naming conflict and unit test failures. Ideally `WP_REST_Navigation_Fallback_Controller` should have been named `WP_REST_Navigation_Fallback_Controller_Gutenberg` and extended `WP_REST_Navigation_Fallback_Controller`. But we can conditionally load the file instead. * Renamed WP_Classic_To_Block_Menu_Converter to Gutenberg_Classic_To_Block_Menu_Converter Load WP_REST_Navigation_Fallback_Controller dependencies in load.php * Renamed all 6.3 classes to have the Gutenberg_ prefix. This should avoid compat errors and hopefully some confusion later. * Also rename test files for completeness * Updated deprecation notices to refer to Gutenberg classes * Fix phpunit failures (#51950) * Fix phpunit failures * Add comment * Update comment with actual reason this fix works --------- Co-authored-by: Dave Smith <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Ramon <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Alex Stine <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
aaronrobertshaw
added
the
Backport to WP 6.7 Beta/RC
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
… Library (WordPress#51897) Brings back WordPress#51492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the link when clicking through from a Browse Mode Library item into focus mode to default to
viewmode rather thanedit.Fixes #51839
Why?
As detailed in the associated Issue, not showing the sidebar means #51492 is effectively hidden from the user.
This PR restores it to be a feature users will actually encounter.
How?
Sets route to
viewrather thanedit.Testing Instructions
Headertemplate part / pattern has a Navigation block with a menu in it.LIbraryin Browse mode and click through to yourHeaderpattern.canvas=viewin it.Testing Instructions for Keyboard
Screenshots or screencast