Block Image: Lightbox - Hide animation selector if behavior is Default or None #51748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12.2 kB (+1%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
cbravobernal
changed the title
cbravobernal
added
[Type] Bug
cbravobernal
commented
Jun 21, 2023
cbravobernal
requested review from
spacedmonkey,
kevin940726,
Mamaduka and
ellatrix
as code owners
|
Flaky tests detected in 07c22ca. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5356751213
|
cbravobernal
force-pushed
the
fix/lightbox-not-working-if-theme-json-undefined
branch
from
da2b0a2
to
4e27cff
Compare
cbravobernal
force-pushed
the
fix/lightbox-not-working-if-theme-json-undefined
branch
from
4e27cff
to
3d083f2
Compare
|
I also added the zoom-out icon on the enlarged image. |
There was a problem hiding this comment.
@c4rl0sbr4v0 I tested with the following config and got the result that when 'Default' is selected, the dropdowns values switch to Lightbox and Zoom in the UI rather than staying on Default with the animation dropdown hidden.
"behaviors": {
"blocks": {
"core/image": {
"lightbox": {
"enabled": true
}
}
}
}
behaviors-animation-dropdown.mp4
True, it seems that the last refactor broke the fix. Will take a look! |
artemiomorales
approved these changes
Jun 23, 2023
cbravobernal
deleted the
fix/lightbox-not-working-if-theme-json-undefined
branch
69 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…t or None (WordPress#51748) * Hide animation selector if default or none * Small refactor, fix on translation * Add zoom out icon * Fix selector, but still dont like the solution * Moved to own function * Add useMemo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Before this PR, if you don't define an animation in theme.json, but you have lightbox enabled defined in the same file, it won't work.
Also, the animation selector should not be displayed if the behavior selected is
NoneorDefaultTesting Instructions
Edit your theme.json file to be like this
Check that the lightbox is working with zoom as default.
Go to post/page edition. Add an Image. Select behavior as
NoneorDefault. The Animation selector should dissapear.