Fix flaky 'Push to Global Styles' e2e test #51636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Jun 19, 2023
| requestUtils.deleteAllTemplates( 'wp_template' ), | ||
| requestUtils.deleteAllTemplates( 'wp_template_part' ), | ||
| ] ); | ||
| await requestUtils.activateTheme( 'emptytheme' ); |
There was a problem hiding this comment.
A small clean-up. The test doesn't create any templates or template parts, so there is no need to delete them.
Mamaduka
commented
Jun 19, 2023
Comment on lines
+17
to
+18
| postId: 'emptytheme//index', | ||
| postType: 'wp_template', |
There was a problem hiding this comment.
Usually, it's better to specify a template or template part in test setups.
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Jun 19, 2023
|
Flaky tests detected in 89b5d58. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5309255597
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Fix flaky 'Push to Global Styles' e2e test * Simplify beforeAll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49942.
PR fixes flaky 'Push to Global Styles' e2e test by better scoping
StylesandSettingsbutton locators.Why?
The button with the label "Styles" is no longer unique in the Site Editor.
Error log
Testing Instructions