Update/page list footer #51438
Merged
Update/page list footer #51438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaxonF
added
the
[Feature] Navigation Component
|
Flaky tests detected in b8cedcd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5252013884
|
|
I don't see any obvious reason why but I get a build error on this PR. Hopefully someone else can check it out. The proposal seems sound. |
|
Size Change: -82 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Jun 14, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* use footer for page navigation screen * updates templates to use nav footer * use footer for page navigation screen * updates templates to use nav footer * use footer for page navigation screen * updates templates to use nav footer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Uses the new footer prop on
SidebarNavigationScreenfor pages and templates.Why?
To keep it consistent with other pages
How?
Moved footer sections out of content and into footer and removed unnecessary css.
Testing Instructions
Testing Instructions for Keyboard