Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor Settings: use v2 DropdownMenu #51400

Closed
wants to merge 35 commits into from
Closed

Block Editor Settings: use v2 DropdownMenu #51400

wants to merge 35 commits into from

Commits on Jun 15, 2023

  1. Start using dropdownmenu v2 in block settings dropdown

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e736ca8 View commit details
    Browse the repository at this point in the history

  2. Add Shortcut component

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6af23df View commit details
    Browse the repository at this point in the history

  3. Refactor block settings dropdown menu items to use dropdownmenu v2

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    bb71a23 View commit details
    Browse the repository at this point in the history

  4. Add notes about duplicate implementations/classnames

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d80301a View commit details
    Browse the repository at this point in the history

  5. Convert more menu items to use the dropdownmenu v2 components

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    53663cb View commit details
    Browse the repository at this point in the history

  6. Convert menu items from the reusable-blocks package to use the dropdo… 

    …wnmenu v2 components
    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    235a841 View commit details
    Browse the repository at this point in the history

  7. Add separator to BlockSettingsMenuControls

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b933e85 View commit details
    Browse the repository at this point in the history

  8. Simplify Shortcut suffix component

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6f50219 View commit details
    Browse the repository at this point in the history

  9. Refactor more menu items rendering inside BlockSettingsMenuControls

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d444e01 View commit details
    Browse the repository at this point in the history

  10. Remove onKeyDown menu props (it doesn't seem to be needed?)

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    04220d4 View commit details
    Browse the repository at this point in the history

  11. Migrate from calling onClose to calling preventDefault() when needing… 

    … to keep the dropdown open
    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    44a5cf3 View commit details
    Browse the repository at this point in the history

  12. Fix broken copy/paste by using native clipboard APIs instead of exter… 

    …nal library
    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    dc78e0d View commit details
    Browse the repository at this point in the history

  13. Remove unnecessary wrapper functions, unused imports, clean up code, … 

    …onClick => onSelect
    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6faf5fd View commit details
    Browse the repository at this point in the history

  14. Add default z-index

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d642c70 View commit details
    Browse the repository at this point in the history

  15. Capture pointer events in modals

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e0075d5 View commit details
    Browse the repository at this point in the history

  16. DropdownMenuV2: accept onKeyDown prop

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4a7a0ac View commit details
    Browse the repository at this point in the history

  17. Restore onKeyDown ev listener on the block settings dropdown

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    40fd830 View commit details
    Browse the repository at this point in the history

  18. Add a few pointer-related props to DropdownMenuItemProps

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a27962e View commit details
    Browse the repository at this point in the history

  19. Destructure and properly allocate more props in Block settings menu

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e5a7b12 View commit details
    Browse the repository at this point in the history

  20. DropdownMenuItem cursor styles

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2c2ae3b View commit details
    Browse the repository at this point in the history

  21. Clean up classnames: 

    - remove duplicate block-editor-block-settings-menu instances in other packages
- remove associated styles (which were not having any effects)
- add new classnames for the triggers (different for each dropdownmenu instance)
- use the new classnames in the react native style overrides
    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    f6c4937 View commit details
    Browse the repository at this point in the history

  22. Temp fix for e2e test

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1141cab View commit details
    Browse the repository at this point in the history

  23. Refactor block settings dropdown to controlled mode. This helps with: 

    - stopping the propagation of the ESC keydown, so that only the dropdown closes and the toolbar stays open
- restoring passing an onClose callback to slotfills, including the create reusable pattern modal
    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    43204d2 View commit details
    Browse the repository at this point in the history

  24. Support rendering anchor tags in DropdownMenuItem

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    0425a81 View commit details
    Browse the repository at this point in the history

  25. Remove done comment

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e51fdcf View commit details
    Browse the repository at this point in the history

  26. Avoid unnecessary function

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    7823fc2 View commit details
    Browse the repository at this point in the history

  27. Set the correct value for aria-labelledby, update e2e tests

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b4e7cc4 View commit details
    Browse the repository at this point in the history

  28. Fix unit test by wrapping the BlockModeToggle in dropdownmenu

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e6342a7 View commit details
    Browse the repository at this point in the history

  29. Sync package-lock.json

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    5347105 View commit details
    Browse the repository at this point in the history

  30. Cleanup code

    @ciampo
    ciampo committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d7dcf02 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Back compat styles for legacy menuitems

    @ciampo
    ciampo committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    3332023 View commit details
    Browse the repository at this point in the history

  2. Resize dropdown menu + show scrollbars when there's not enough space

    @ciampo
    ciampo committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    02a2e0a View commit details
    Browse the repository at this point in the history

  3. Forward ref on DropdownMenu component

    @ciampo
    ciampo committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    1c5aef5 View commit details
    Browse the repository at this point in the history

  4. Allow specifying container on useCopyToClipboard hook

    @ciampo
    ciampo committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    b53783e View commit details
    Browse the repository at this point in the history

  5. Revert to using useCopyToCliboard hook

    @ciampo
    ciampo committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    601a07e View commit details
    Browse the repository at this point in the history