Remove Details block setting field from the experiments page #51372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
[Block] Details
ndiego
approved these changes
Jun 10, 2023
|
Thanks for the review, @ndiego! |
t-hamano
added
the
Gutenberg Plugin
ndiego
added
the
Backport to Gutenberg RC
ndiego
removed
the
Backport to Gutenberg RC
|
I mistakenly thought this needed to be included in 16.0, hence all the label/milestone updates. The Details block setting is in fact, removed from 16.0, so no backport needed. This PR just needs to be included in 16.1. Sorry for any confusion. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #50030
Related to: #50997
What?
This PR removes Details block setting field from the experiments page.
Why?
The Details block was stabilized in #50997. The setting field has been removed from the Experiments page accordingly.
However, in #50983, the setting appears to have been restored. Perhaps an unintended line change was made due to merge timing.
Testing Instructions
Access the Experiments page and confirm that the setting field for the Details block is not present.